Add testing workflow and use pytest#315
Conversation
smokestacklightnin
force-pushed
the
ci/testing/use-pytest
branch
from
b67afcf to
230e73a
Compare
peytondmurray
left a comment
peytondmurray
left a comment
There was a problem hiding this comment.
Wow, the amount of code we save from doing test collection with pytest is big. Just a few comments about the dependencies, otherwise this looks good.
|
Looks like there are also PicklingErrors - are these related to the problem you mentioned? |
peytondmurray
left a comment
peytondmurray
left a comment
There was a problem hiding this comment.
After discussion, I'm changing this to a request for changes until we understand the PicklingError.
|
For now, my plan is to add |
|
Test workflows are passing now that we xfail and skip classes with failing tests |
smokestacklightnin
dismissed
peytondmurray’s stale review
Changes have been made
smokestacklightnin
changed the title
pytestpytest
|
this lib is synced from the internal codebase -- the other way does not happen automatically. all the changes will get reverted on the next internal -> github sync. you'd have to make internal change instead |
|
Do you have access to the internal codebase?
If not, you'd have to ask someone with the access to either:
1) port the PR manually and submit it to the internal codebase, or, since
I'm assuming this is not the last change you're planning to make, it's
better to:
2) configure two-way porting workflow github <-> internal. It would be
quite a bit of work since all migration changes will have to be made
reversible, but in the long run it will allow submitting from github.
…On Thu, Sep 12, 2024 at 5:14 PM William Black ***@***.***> wrote:
this lib is synced from the internal codebase -- the other way does not
happen automatically. all the changes will get reverted on the next
internal -> github sync. you'd have to make internal change instead
@iindyk <https://github.com/iindyk> What would be the best way to have my
and my colleagues' ***@***.*** <https://github.com/peytondmurray>,
@aktech <https://github.com/aktech>) merged into the repo? We're from
Quansight doing consulting for Google.
—
Reply to this email directly, view it on GitHub
<#315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQN6OJ3PEYLJ3T74K22ARLZWIU6PAVCNFSM6AAAAABMTDALIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGQ2DGMZYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
smokestacklightnin
changed the title
pytestpytest
|
Closing this PR out for now, as there is not currently a path forward for community contributions yet. |
|
Reopening, as |
|
@peytondmurray tests are passing |
3 participants
Here is a summary of what is included in this PR:
if __name__ == "__main__"section from tests because it is not necessary, or even run, when using pytest. Nontrivial functionality from those sections was preserved.README.mdto reflect changesxfailmark to classes with failing tests